Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DashboardBundle] change google api library #1872

Closed
wants to merge 2 commits into from

Conversation

sandergo90
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? yes
Fixed tickets #1781

In preparation of issue #1781, I removed the old google api that we forked from alchemy/google-plus-api-client and changed if with the official google api client. Therefore some BC breaks are introduced, because some classes are having a different name.

In a next PR, when google-api-client is ready for Analytics V4, we can change our bundles again. Probably this will be done before the 6.0 release so we don't have to BC break twice.

I also did a lot of cleanup in the DashboardBundle!

@Numkil
Copy link
Contributor

Numkil commented Mar 30, 2018

@sandergo90 can you rebase this PR? I think most of the content here isn't supposed to be included in the PR

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sandergo90, your PR needs some changes

  • your PR title should look like [SomeBundle] Fixed some code

Devolicious and others added 2 commits May 15, 2018 17:02
* master: (93 commits)
  Pass correct constructor arguments to the translator service (Kunstmaan#1968)
  Mark services used in controller as public (Kunstmaan#1972)
  Fix unquoted parameter in routing generator (Kunstmaan#1973)
  [UtilitiesBundle] Make parameter kunstmaan_utilities.cipher.secret op… (Kunstmaan#1939)
  Revert "[GeneratorBundle] Remove unused .babelrc (Kunstmaan#1950)"
  [KunstmaanFormBundle]: batchsize is not initialized (Kunstmaan#1976)
  Fixed active menu item when having more than 1 configuration entity (Kunstmaan#1964)
  Make the router service alias public (Kunstmaan#1969)
  Mark the translator service aliases as public (Kunstmaan#1970)
  Fixed yaml translation file deprecations (Kunstmaan#1971)
  [AdminListBundle] fixes forgotten commit new feature changeablelimitinterface (Kunstmaan#1967)
  [NodeSearchBundle]: elasticsearch util should check the running version of elasticsearch (Kunstmaan#1940) (Kunstmaan#1965)
  [AdminListBundle][MediaBundle] Changeablelimitinterface implemented and fixes some bugs (Kunstmaan#1905)
  Deprecate container usage in the slug router (Kunstmaan#1960)
  [AllBundles] Implement reset method in datacollectors (Kunstmaan#1959)
  [AdminBundle] update frontend packages (Kunstmaan#1946)
  [AdminBundle] Messages are already translated by symfony (Kunstmaan#1954)
  Bundle default config reference docs (Kunstmaan#1951)
  [GeneratorBundle] Remove unused .babelrc (Kunstmaan#1950)
  [TranslatorBundle]: change toolbar data collector to show message (Kunstmaan#1947)
  ...

[AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767)

* Unused method, property, variable or parameter

* Unused variable

* Update BundleVersionDataCollector.php

* DocBlock fix

[AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767)

* Unused method, property, variable or parameter

* Unused variable

* Update BundleVersionDataCollector.php

* DocBlock fix

[AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767)

* Unused method, property, variable or parameter

* Unused variable

* Update BundleVersionDataCollector.php

* DocBlock fix

[AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767)

* Unused method, property, variable or parameter

* Unused variable

* Update BundleVersionDataCollector.php

* DocBlock fix

[AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767)

* Unused method, property, variable or parameter

* Unused variable

* Update BundleVersionDataCollector.php

* DocBlock fix

[UtilitiesBundle] Commands as services and mark commands as final (Kunstmaan#1789)

[NodeBundle] Commands as services and mark commands as final (Kunstmaan#1791)

[TranslatorBundle] Commands as services and mark commands as final (Kunstmaan#1788)

[AdminListBundle][5.1] Deprecate direct container access in controllers (Kunstmaan#1769)

[AdminBundle] refactor media token transformer (Kunstmaan#1827)

[AdminListBundle] Fix Export Exception namespace (Kunstmaan#1825)

[AdminBundle]: readd the extrajavascript block (Kunstmaan#1829)

[MediaBundle] Bulk upload fix (Kunstmaan#1834)

[AdminListBundle]: ->loadTemplate() is only for internal use.. (Kunstmaan#1846)

[PagePartBundle] Fix for PHP 7.2 - value passed to count() cannot be null (Kunstmaan#1849)

update changelog

update changelog

[AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831)

[LeadGenerationBundle]: remove jquery dependency leadgeneration bundle (Kunstmaan#1859)

Reset event listeners after submit + fixed serialization of form data

[LeadGenerationBundle]: add extras

[NodeBundle]: improve URL chooser external (Kunstmaan#1852)

[AllBundles] 5.1 upgrade file with all current changes (Kunstmaan#1850)

[NodeBundle]: deprecate service function (Kunstmaan#1840)

[AllBundles]: Linting changes (Kunstmaan#1867)

Change the eslint config for the AdminBundle to make it lint the code inside the jsnext folder instead of the js folder

Remove all other eslint / stylelint config

[DashboardBundle]: add new google api client
Check if access token is expired

Add 6.0 upgrade guide

Upgrade guide for 6.0
@sandergo90 sandergo90 changed the title [DashboardBundle]: change google api library [DashboardBundle] change google api library May 15, 2018
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sandergo90, your PR passed all our requirements.

Thank you for contributing!

@acrobat
Copy link
Member

acrobat commented May 15, 2018

Can't we create BC friendly version of this pr or a separate layer that can be introduced in 5.x so we can deprecate the old layer?

@tarjei
Copy link
Contributor

tarjei commented Jan 14, 2019

For 5.x is it possible to move the dependency into suggests or will that also break all code inside the bundle?

I just want to write some stuff to google sheets and it seems I'll have to define a whole separate project due to this dependency...

@tarjei
Copy link
Contributor

tarjei commented Jan 14, 2019

I'm sorry for hijacking this thread, but I thought I'd leave this comment somewhere someone would find it.

if you need to combine modern google apis with version 5.x and you can forgo the nice analytics dashboard, you can do the following:

  1. Disable loading the old api in composer.json by adding to the autoload key:
{
"autoload": 
  {
     "exclude-from-classmap": ["vendor/kunstmaan/google-api-custom/*"]
  }
}
  1. Create a dummy config service for the frontend:
services:
  kunstmaan_dashboard.helper.google.analytics.config:
      class: SiteBundle\Dashboard\DummyConfigHelper
/**
 * Overide dashboard config to not connect to google using the old api that has been removed.
 */
class DummyConfigHelper
{

    public function tokenIsSet(): bool
    {
        return false;
    }

    public function getAuthUrl() : string
    {
        return "https://www.novap.no";
    }

}

@acrobat acrobat modified the milestones: 6.0.0, Unknown (WIP) Jun 25, 2020
@Devolicious Devolicious closed this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants