New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AdminBundle][MultiDomainBundle] deprecated service container usage i… #1992
[AdminBundle][MultiDomainBundle] deprecated service container usage i… #1992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @deZinc, your PR needs some changes
- It seems that our checklist is missing or incomplete
a8f9b5c
to
10d1b32
Compare
); | ||
* @param ContainerInterface|string $multilanguage | ||
*/ | ||
public function __construct(/*ContainerInterface|multilanguage string*/ $multilanguage, $defaultLocale = null, $requiredLocales = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the |multilanguage, this should be ContainerInterface|string
*/ | ||
public function __construct(ContainerInterface $container) | ||
public function __construct(/*ContainerInterface|multilanguage string*/ $multilanguage, $defaultLocale = null, $requiredLocales = null, AdminRouteHelper $adminRouteHelper = null, EntityManagerInterface $em = null, array $hosts = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idem
…n domain configuration
10d1b32
to
7b980ad
Compare
* master: [AdminBundle] updated aclUpdateCommand to use AclManager (#2001) Inject correct services/parameters so our code doesn't trigger deprections (#2006) [NodeBundle] Reword deprecation message and provide alternative to the end-user (#2004) [AdminBundle][NodeBundle] added new AclManager to handle acl dependency injections (#1999) [UserManagementBundle][SeoBundle] Deprecate direct container access in controllers (#1998) [AdminBundle][UserManagementBundle] marked service as public using compilerpass (#1997) [TranslatorBundle] Fix container deprecations with translation loaders (#2005) [KunstmaanNodeSearchBundle]: remove check for class (#2009) Select correct root node for multidomain setup and use multidomain config id (#1986) [AdminBundle][MultiDomainBundle] deprecated service container usage in domain configuration (#1992) [AdminBundle] marked service as public (#1991) [AdminBundle] Extend Role from base symfony class (#1981) Mark services used in controller as public (#1979) Deprecate service container usage in commands (#1974) [SearchBundle] Deprecate service container usage in commands (#1978) Fix UtilitiesExtensionTest after upmerge from 5.0 (#1977) Change labels to required (#1962)
…n domain configuration