[UserManagementBundle][SeoBundle] Deprecate direct container access i… #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
suggested changes
May 31, 2018
There was a problem hiding this comment.
Hi @deZinc, your PR needs some changes
- It seems that our checklist is missing or incomplete
deZinc
force-pushed
the
fix/base-settings-controller
branch
from
a6cf054
to
a661658
Compare
Devolicious
approved these changes
Jun 8, 2018
ProfessorKuma
approved these changes
Jun 8, 2018
There was a problem hiding this comment.
Hi @deZinc, your PR passed all our requirements.
Thank you for contributing!
Devolicious
added a commit
that referenced
this pull request
Jun 8, 2018
* master: [AdminBundle] updated aclUpdateCommand to use AclManager (#2001) Inject correct services/parameters so our code doesn't trigger deprections (#2006) [NodeBundle] Reword deprecation message and provide alternative to the end-user (#2004) [AdminBundle][NodeBundle] added new AclManager to handle acl dependency injections (#1999) [UserManagementBundle][SeoBundle] Deprecate direct container access in controllers (#1998) [AdminBundle][UserManagementBundle] marked service as public using compilerpass (#1997) [TranslatorBundle] Fix container deprecations with translation loaders (#2005) [KunstmaanNodeSearchBundle]: remove check for class (#2009) Select correct root node for multidomain setup and use multidomain config id (#1986) [AdminBundle][MultiDomainBundle] deprecated service container usage in domain configuration (#1992) [AdminBundle] marked service as public (#1991) [AdminBundle] Extend Role from base symfony class (#1981) Mark services used in controller as public (#1979) Deprecate service container usage in commands (#1974) [SearchBundle] Deprecate service container usage in commands (#1978) Fix UtilitiesExtensionTest after upmerge from 5.0 (#1977) Change labels to required (#1962)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the code to move away from direct container access in controllers. All
$this->get()usages are replaced by$this->container->get()to avoid triggering deprecations in non-user code. In 6.0 we should:getandgetParameteroverridesAbstractControllergetSubscribedServicesmethod to extend the list of services to make sure we have all the "default" symfony services and the ones controllers extending the BaseSettingsController need in the service locator. Users extending from this BaseSettingsController should just register their controllers as services.This is just for controllers extending the base. Separate PRs will handle further container access deprecations.