-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PagePartBundle] Refactor HeaderPagePart entity test #2024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Devolicious, your PR needs some changes
- This PR seems to need a milestone of a patch release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Devolicious, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for fixing this @Devolicious, I didn't had the time yet to look into it!
@acrobat No prob :) |
* 5.0: recompiled assets update changelog refactor HeaderPagePart entity test (#2024) [NodeBundle] fixed issue 1581, save on (un)publish (#1803) Replace deprecated twig raw tag in scss file (#1987) [KunstmaanAdminBundle]: fix js for collections (#1989) [Docs] set correct paths (#1990) [AdminBundle] fixed create user command #1995 (#1996)
* master: (24 commits) added missing translations to main language (#2038) bump node version (#2035) recompile assets after upmerge recompiled assets update changelog [NodeBundle] Split off logic of NodeAdminController in helper class (#2027) refactor HeaderPagePart entity test (#2024) [AllBundle] move old phpunit style to codeception with fixed coverage (#1955) [Docs] remove vagrant references and put some small snippet about docker in (#1953) Add target blank to download link (#1963) [NodeBundle] fixed issue 1581, save on (un)publish (#1803) Replace deprecated twig raw tag in scss file (#1987) [KunstmaanAdminBundle]: fix js for collections (#1989) [Docs] set correct paths (#1990) [AdminBundle] fixed create user command #1995 (#1996) [AdminBundle] Deprecate service container usage in commands (#2014) [AdminBundle] updated aclApplyCommand to use AclManager (#2003) Replace getParameter calls so our code doesn't trigger deprecations (#2012) [AdminBundle][MultidomainBundle] Move parameter checks and service definition changes to compiler pass (#2018) Mark extra services public (#2013) ...
This fixes the HeaderPagePart entity test