[NodeBundle] Split off logic of NodeAdminController in helper class #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
approved these changes
Jun 18, 2018
There was a problem hiding this comment.
Hi @treeleaf, your PR passed all our requirements.
Thank you for contributing!
Devolicious
suggested changes
Jun 19, 2018
| arguments: | ||
| - "@doctrine.orm.entity_manager" | ||
| - "@kunstmaan_node.admin_node.publisher" | ||
| - "@kunstmaan_node.admin_node.node_version_lock_helper" |
There was a problem hiding this comment.
@treeleaf This argument does not match the constructor of the NodeHelper
| - "@security.token_storage" | ||
| - "@kunstmaan_admin.clone.helper" | ||
| - "@event_dispatcher" | ||
| - { timeout: "%kunstmaan_node.version_timeout%"} |
There was a problem hiding this comment.
This parameter is also not available in the constructor method.
Devolicious
approved these changes
Jun 20, 2018
Devolicious
added a commit
that referenced
this pull request
Jun 26, 2018
* master: (24 commits) added missing translations to main language (#2038) bump node version (#2035) recompile assets after upmerge recompiled assets update changelog [NodeBundle] Split off logic of NodeAdminController in helper class (#2027) refactor HeaderPagePart entity test (#2024) [AllBundle] move old phpunit style to codeception with fixed coverage (#1955) [Docs] remove vagrant references and put some small snippet about docker in (#1953) Add target blank to download link (#1963) [NodeBundle] fixed issue 1581, save on (un)publish (#1803) Replace deprecated twig raw tag in scss file (#1987) [KunstmaanAdminBundle]: fix js for collections (#1989) [Docs] set correct paths (#1990) [AdminBundle] fixed create user command #1995 (#1996) [AdminBundle] Deprecate service container usage in commands (#2014) [AdminBundle] updated aclApplyCommand to use AclManager (#2003) Replace getParameter calls so our code doesn't trigger deprecations (#2012) [AdminBundle][MultidomainBundle] Move parameter checks and service definition changes to compiler pass (#2018) Mark extra services public (#2013) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR some logic that is in the NodeAdminController is being put in a helper service class. Currently no changes in the controller yet: the controller will not yet use this code. It will be done in a future PR.