[AllBundles] rollback sensio framework extra bundle version #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
suggested changes
Jun 25, 2018
There was a problem hiding this comment.
Hi @deZinc, your PR needs some changes
- It seems that you should have submitted to the latest minor branch.
- This PR seems to need a milestone of a patch release.
ProfessorKuma
suggested changes
Jun 25, 2018
There was a problem hiding this comment.
Hi @deZinc, your PR needs some changes
- It seems that you should have submitted to the latest minor branch.
- This PR seems to need a milestone of a patch release.
ProfessorKuma
suggested changes
Jun 25, 2018
There was a problem hiding this comment.
Hi @deZinc, your PR needs some changes
- It seems that you should have submitted to the latest minor branch.
- This PR seems to need a milestone of a patch release.
ProfessorKuma
suggested changes
Jun 25, 2018
There was a problem hiding this comment.
Hi @deZinc, your PR needs some changes
- It seems that you should have submitted to the latest minor branch.
- This PR seems to need a milestone of a patch release.
ProfessorKuma
suggested changes
Jun 25, 2018
There was a problem hiding this comment.
Hi @deZinc, your PR needs some changes
- It seems that you should have submitted to the latest minor branch.
- This PR seems to need a milestone of a patch release.
ProfessorKuma
approved these changes
Jun 26, 2018
There was a problem hiding this comment.
Hi @deZinc, your PR passed all our requirements.
Thank you for contributing!
|
Closing this PR as a fix for the BC break is provided in #2045 whiling keeping the latest version of the framework-extra-bundle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to downgrade the sensio framework-extra-bundle because in v4.0 there's a BC break that causes issues with our templates. We'll have to rethink this further down the line for the sf4 compatibility.