[AllBundles] Fix BC break after upgrading to sensio/framework-extra-bundle 5.0 #2045
Conversation
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
acrobat
force-pushed
the
bc-upgrade-framework-extra-bundle
branch
from
ab887b1
to
3f05b43
Compare
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
| @@ -438,7 +436,6 @@ private function createAndRedirect(Request $request, $folderId, $type, $redirect | |||
| * | |||
| * @Route("create/modal/{folderId}/{type}", requirements={"folderId" = "\d+", "type" = ".+"}, name="KunstmaanMediaBundle_media_modal_create") | |||
| * @Method({"GET", "POST"}) | |||
| * @Template() | |||
| * | |||
There was a problem hiding this comment.
method 'createAndRedirect' can still return an array. In that case it could break. So either 'createAndRedirect' should be adapted or a default template should be provided.
There was a problem hiding this comment.
Good catch! I'm not sure this method is actually used anymore. I can only find 1 usage in the code, but I don't know yet how to "trigger" that usage. Currently there is no corresponding twig template for this action, so I will look into this.
There was a problem hiding this comment.
This action was not used as a "GET" anywhere only as a POST for the add file/image/video popup. So I've removed GET as allowed method. Also this code couldn't have worked before as the is no template createModal.html.twig or create_modal.html.twig
There was a problem hiding this comment.
Thanks for fixing a three year old bug
acrobat
force-pushed
the
bc-upgrade-framework-extra-bundle
branch
from
3f05b43
to
a688e66
Compare
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
acrobat
force-pushed
the
bc-upgrade-framework-extra-bundle
branch
from
a688e66
to
7fa19df
Compare
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
|
This PR is ready for review/merge |
Upgrading to sensio/framework-extra-bundle 5.0 caused a bc break for camelcase template paths which were not explicitly configured (Symfony would guess the template path for the empty
@Template()annotations. This is fixed by explicitly settings the template path for these cases.I've also remove some unused
@Templateannotations as these actions returned a redirect so the annotation was unused.