[AdminListBundle] fixed form options source in admin list controller #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
suggested changes
Jul 18, 2018
There was a problem hiding this comment.
Hi @mdxpl, your PR needs some changes
- It seems that our checklist is missing or incomplete
ProfessorKuma
suggested changes
Jul 18, 2018
There was a problem hiding this comment.
Hi @mdxpl, your PR needs some changes
- This PR seems to need a milestone of a patch release.
ProfessorKuma
approved these changes
Jul 18, 2018
There was a problem hiding this comment.
Hi @mdxpl, your PR passed all our requirements.
Thank you for contributing!
Devolicious
approved these changes
Jul 18, 2018
janb87
pushed a commit
to janb87/KunstmaanBundlesCMS
that referenced
this pull request
Aug 1, 2018
Devolicious
added a commit
that referenced
this pull request
Aug 7, 2018
* 5.0: recompile assets update changelog Remove id of nested form item containers (#2049) Fix empty url in admin list (#2071) [MediaBundle] fixed BackgroundFilterLoader issue (#2028) [MediaBundle] Skip test if ghostscript is not installed (#2066) [NodeBundle] Removed unused use of the VarDumper class (#2067) #2050 Fixed issue in refreshing ck editor (don't do a destroy if the instance is already initializing) (#2064) [KunstmaanTranslatorBundle]: export all translations, use correct locales (#2055) [AdminListBundle] fixed form options from AdaptSimpleFormEvent in admin list (#2056) [GeneratorBundle] Fix xpath for publish modal in behat tests (#2052) [AdminBundle] fixed BC break in CreateUserCommand (#2043) remove hardcopy of ckeditor (#2041)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AdminListController type options come from the configuration. They are passed to the AdaptSimpleFormEvent but then form factory use the same array.
Due to the array isn't passed to the event by reference it's impossible to modify form options in the AdaptSimpleFormEvent listener.
I have passed to the form factory options from the event rather than configuration.