Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MediaBundle] Skip test if ghostscript is not installed #2066

Merged

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Aug 2, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

When running tests on your local machine ghostscript might not be installed. So this tests fails everytime. Skip the test when ghostscript is not installed, on travis ghostscript will be available.

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@Devolicious Devolicious merged commit fc6bfa6 into Kunstmaan:5.0 Aug 7, 2018
@acrobat acrobat deleted the mediabundle-skip-ghostscript-test branch August 7, 2018 10:19
Devolicious added a commit that referenced this pull request Aug 7, 2018
* 5.0:
  recompile assets
  update changelog
  Remove id of nested form item containers (#2049)
  Fix empty url in admin list (#2071)
  [MediaBundle] fixed BackgroundFilterLoader issue (#2028)
  [MediaBundle] Skip test if ghostscript is not installed (#2066)
  [NodeBundle] Removed unused use of the VarDumper class (#2067)
  #2050 Fixed issue in refreshing ck editor (don't do a destroy if the instance is already initializing) (#2064)
  [KunstmaanTranslatorBundle]: export all translations, use correct locales (#2055)
  [AdminListBundle] fixed form options from AdaptSimpleFormEvent in admin list (#2056)
  [GeneratorBundle] Fix xpath for publish modal in behat tests (#2052)
  [AdminBundle] fixed BC break in CreateUserCommand (#2043)
  remove hardcopy of ckeditor (#2041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants