New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MediaBundle] Add web_root configuration to support both web and public as the root dir for uploads #2058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
d6db812
to
7d27857
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
…ic as the root dir for uploads
7d27857
to
fc3cba3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
@acrobat Thanks for adding new tests! It will only make our CMS better! |
In sf4 the web root was moved from
web
topublic
but the web directory was hardcoded for the full media upload path in our code. This change adds a configuration option to the mediabundle to override the web root path. Default it will use the symfony kernel version to set a sensible default value,web
for <sf4 andpublic
for >sf4.