[MediaBundle] Fix issues with CreatePdfPreviewCommand #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
approved these changes
Sep 6, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1974 a duplicate yaml key was introduced so the command couldn't be loaded. And in #2058 I've introduced the dynamic web/public parameter, but it was not used in this command making it not usable for sf4. Changing the parameter befor the 5.1 release allows us to change it without breaking BC!