[AdminBundle] Update _form-group.scss #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
suggested changes
Dec 13, 2018
There was a problem hiding this comment.
Hi @rmibelgium, your PR needs some changes
- It seems that our checklist is missing or incomplete
- your PR title should look like
[SomeBundle] Fixed some code
ProfessorKuma
previously requested changes
Jan 14, 2019
There was a problem hiding this comment.
Hi @rmibelgium, your PR needs some changes
- Your answer if this PR is BC breaking seems to be incorrect.
- It seems that you should have submitted to the latest minor branch.
- This PR seems to need a milestone of a patch release.
FVKVN
reviewed
Jan 14, 2019
| @@ -16,6 +16,10 @@ | |||
| max-width: none; | |||
| } | |||
|
|
|||
| .form-group--no-max-width textarea { | |||
There was a problem hiding this comment.
Could you group both selectors instead of duplicating the style declaration.
In our cms, rawHtml type didn't respect the form-group--no-max-width because the textarea under has class form-control which overwrite with max-width: 40rem;
Numkil
approved these changes
Jan 24, 2019
Devolicious
added a commit
that referenced
this pull request
Feb 8, 2019
* 5.1: update changelog updated changelog [AdminBundle] fix error state for select2 & wysiwyg fields (#2352) [AdminBundle] Revert PR #2049 changes (#2283) [ArticleBundle] Fixed missing sprintf with classname in deprecation message (#2334) [GeneratorBundle] Fix incorrect plural of certain table names (#2277) [Admin][Cache][Config][Generator][Pagepart] fix some routes that didn't use the configurable admin prefix (#2266) [AllBundles] Remove php 7.3 check as php-cs-fixer supports it now [AdminBundle] Update _form-group.scss (#2199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our cms, rawHtml type didn't respect the form-group--no-max-width because the textarea under has class form-control which overwrite with max-width: 40rem;