[FormBundle] Moved FormMailer dependency to separate listener #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
suggested changes
Feb 27, 2019
There was a problem hiding this comment.
Hi @devigner, your PR needs some changes
- your PR title should look like
[SomeBundle] Fixed some code
devigner
changed the title
ProfessorKuma
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Hi @devigner, your PR passed all our requirements.
Thank you for contributing!
|
The 'SymfonyInsight: kunstmaanlabs / KunstmaanBundlesCMS' failure is caused by code outside my PR. |
Devolicious
suggested changes
Mar 8, 2019
| @@ -3,6 +3,7 @@ | |||
| namespace Kunstmaan\FormBundle\Event; | |||
|
|
|||
| use Kunstmaan\FormBundle\Entity\FormSubmission; | |||
| use Kunstmaan\FormBundle\Helper\FormPageInterface; | |||
| use Kunstmaan\NodeBundle\Entity\AbstractPage; | |||
There was a problem hiding this comment.
Can you switch out all of the AbstractPage typehints because this is an unused use statement now.
Devolicious
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved sending the email to a listener. The listener can be removed when no email needs to be send after form submission. For example when the form submission is used to create a MailChimp user.