Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormBundle] Moved FormMailer dependency to separate listener #2391

Merged
merged 4 commits into from
Mar 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Kunstmaan/FormBundle/Event/SubmissionEvent.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Kunstmaan\FormBundle\Event;

use Kunstmaan\FormBundle\Entity\FormSubmission;
use Kunstmaan\NodeBundle\Entity\AbstractPage;
use Kunstmaan\FormBundle\Helper\FormPageInterface;
use Symfony\Component\EventDispatcher\Event;

class SubmissionEvent extends Event
Expand All @@ -14,15 +14,15 @@ class SubmissionEvent extends Event
protected $submission;

/**
* @var AbstractPage
* @var FormPageInterface
*/
protected $page;

/**
* @param FormSubmission $submission
* @param AbstractPage $page
* @param FormSubmission $submission
* @param FormPageInterface $page
*/
public function __construct(FormSubmission $submission, AbstractPage $page)
public function __construct(FormSubmission $submission, FormPageInterface $page)
{
$this->submission = $submission;
$this->page = $page;
Expand All @@ -37,7 +37,7 @@ public function getSubmission()
}

/**
* @return AbstractPage
* @return FormPageInterface
*/
public function getPage()
{
Expand Down
43 changes: 43 additions & 0 deletions src/Kunstmaan/FormBundle/EventListener/SendEmailListener.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?php

namespace Kunstmaan\FormBundle\EventListener;

use Kunstmaan\FormBundle\Event\SubmissionEvent;
use Kunstmaan\FormBundle\Helper\FormMailerInterface;

/**
* An event listener for sending an email after the form submission is completed
*/
class SendEmailListener
{
/**
* @var FormMailerInterface
*/
private $formMailer;

/**
* @param FormMailerInterface $formMailer The form Mailer
*/
public function __construct(FormMailerInterface $formMailer)
{
$this->formMailer = $formMailer;
}

/**
* Configure the form submissions link on top of the form in the sub action menu
*
* @param SubmissionEvent $event
*/
public function onSubmission(SubmissionEvent $event)
{
$page = $event->getPage();
$formSubmission = $event->getSubmission();

$from = $page->getFromEmail();
$to = $page->getToEmail();
$subject = $page->getSubject();
if (!empty($from) && !empty($to) && !empty($subject)) {
$this->formMailer->sendContactMail($formSubmission, $from, $to, $subject);
}
}
}
8 changes: 0 additions & 8 deletions src/Kunstmaan/FormBundle/Helper/FormHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,6 @@ public function handleForm(FormPageInterface $page, Request $request, RenderCont
$event = new SubmissionEvent($formSubmission, $page);
$this->container->get('event_dispatcher')->dispatch(FormEvents::ADD_SUBMISSION, $event);

$from = $page->getFromEmail();
$to = $page->getToEmail();
$subject = $page->getSubject();
if (!empty($from) && !empty($to) && !empty($subject)) {
$mailer = $this->container->get('kunstmaan_form.form_mailer');
$mailer->sendContactMail($formSubmission, $from, $to, $subject);
}

return new RedirectResponse($page->generateThankYouUrl($router, $context));
}
}
Expand Down
7 changes: 7 additions & 0 deletions src/Kunstmaan/FormBundle/Resources/config/services.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
parameters:
kunstmaan_form.form_mailer.class: 'Kunstmaan\FormBundle\Helper\FormMailer'
kunstmaan_form.form_handler.class: 'Kunstmaan\FormBundle\Helper\FormHandler'
kunstmaan_form.sendemail_listener.class: 'Kunstmaan\FormBundle\EventListener\SendEmailListener'

services:
kunstmaan_form.menu.adaptor.forms:
Expand All @@ -23,3 +24,9 @@ services:
arguments: ['@doctrine.orm.entity_manager', '@router']
tags:
- { name: 'kernel.event_listener', event: 'kunstmaan_node.configureSubActionMenu', method: 'onSubActionMenuConfigure' }

kunstmaan_form.send_email_listener:
class: "%kunstmaan_form.sendemail_listener.class%"
arguments: ['@kunstmaan_form.form_mailer']
tags:
- { name: 'kernel.event_listener', event: 'kunstmaan_form.add_submission', method: 'onSubmission' }