[FormBundle][GeneratorBundle] Fix constraints on form pageparts #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
previously requested changes
Apr 30, 2019
There was a problem hiding this comment.
Hi @Devolicious, your PR needs some changes
- It seems that you should have submitted to the latest minor branch.
acrobat
added a commit
to acrobat/KunstmaanBundlesCMS
that referenced
this pull request
May 20, 2019
* master: Bump composer branch alias for 5.4.0 development Update changelog for 5.3.0 release Update changelog for 5.2.5 release New Crowdin translations (Kunstmaan#2437) [FormBundle][GeneratorBundle] Fix constraints on form pageparts (Kunstmaan#2436) [AdminListBundle] [TranslatorBundle] Option to filter on empty fields in StringFilterType. (Kunstmaan#2434) [AdminBundle] fix timepicker of publish & unpublish modals (Kunstmaan#2431) fix admin test generator (Kunstmaan#2432) Fix addField docblock param for AbstractAdminListConfigurator (Kunstmaan#2433) [NodeBundle] Register services that enable the node bundle entity tabs (Kunstmaan#2430) [GeneratorBundle] Added fos user config to generator (Kunstmaan#2427)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The form pageparts use the default
constraintsoption to pass the constraints from theadaptFormmethod to the actual form. Problem is that this will set the constraints on the parent Form object also which means that if you have for instance aSingleLineTextPagePartthat is not required and used a pattern to be filled in, the form will be stuck because of the constraints that are set on theStringFormSubmissionTypewhile the validation on thevalueproperty passes.