[GeneratorBundle] Added fos user config to generator #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
suggested changes
Apr 11, 2019
There was a problem hiding this comment.
Hi @Devolicious, your PR needs some changes
- This PR seems to need a milestone of a minor release.
ProfessorKuma
approved these changes
Apr 11, 2019
There was a problem hiding this comment.
Hi @Devolicious, your PR passed all our requirements.
Thank you for contributing!
Devolicious
changed the title
acrobat
added a commit
that referenced
this pull request
May 10, 2019
* master: (319 commits) [AdminListBundle] [TranslatorBundle] Option to filter on empty fields in StringFilterType. (#2434) fix admin test generator (#2432) Fix addField docblock param for AbstractAdminListConfigurator (#2433) [NodeBundle] Register services that enable the node bundle entity tabs (#2430) [GeneratorBundle] Added fos user config to generator (#2427) [NodeBundle] Allow entity as creator (#2429) [AllBundle] Separate bundle phpunit config and cleanup old files (#2419) check if db_driver has been configured as it cannot be overwritten (#2425) [AdminBundle] dynamic breakpoint for top navbar in admin area (#2375) [AdminBundle] update Bootstrap v3.3 -> v3.4 (#2424) [Documentation] KunstmaanCMS Installer documentation (#2418) [AdminBundle] fix typo in filename of wordcount (#2423) [FormBundle] In newer versions of symfony the @templating service is changed to the delegatingengine instead of the twigengine (#2422) [AllBundles] Replace deprecated getRootDir calls (#2421) [NodeBundle] Remove old/incorrect doc about lock command (#2420) fix null check (#2417) [GeneratorBundle] Added config generator + improved install command (#2414) [NodeBundle] Import commands.yml to register command in sf4 (#2415) [NodeBundle] Fix for missing validation of url/email link chooser (#2413) [AllBundles] added link script for development (#2412) ...
acrobat
added a commit
to acrobat/KunstmaanBundlesCMS
that referenced
this pull request
May 20, 2019
* master: Bump composer branch alias for 5.4.0 development Update changelog for 5.3.0 release Update changelog for 5.2.5 release New Crowdin translations (Kunstmaan#2437) [FormBundle][GeneratorBundle] Fix constraints on form pageparts (Kunstmaan#2436) [AdminListBundle] [TranslatorBundle] Option to filter on empty fields in StringFilterType. (Kunstmaan#2434) [AdminBundle] fix timepicker of publish & unpublish modals (Kunstmaan#2431) fix admin test generator (Kunstmaan#2432) Fix addField docblock param for AbstractAdminListConfigurator (Kunstmaan#2433) [NodeBundle] Register services that enable the node bundle entity tabs (Kunstmaan#2430) [GeneratorBundle] Added fos user config to generator (Kunstmaan#2427)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted not to remove the FosUserConfig prepend because it fixes an error that is not in the default FosUser recipe. Specifically the
group_class. If that is not present there is nogroupmanagerand that is a dependency we use in theCreateUserCommandand in theFixUserManagerPasscompiler pass. So I added the config we now have in the StandardEdition to the generator with the 3 required properties also. That is something we can leave out if we want and only add the email section like we do in the StandardEdition. Up for debate :)