Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ArticleBundle] Code improvement found by static code analysis #2468

Merged
merged 1 commit into from Jun 11, 2019
Merged

[ArticleBundle] Code improvement found by static code analysis #2468

merged 1 commit into from Jun 11, 2019

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented May 21, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

@acrobat acrobat added this to the 5.4.0 milestone May 21, 2019
ProfessorKuma
ProfessorKuma approved these changes May 21, 2019
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@Devolicious Devolicious merged commit a2c5ce3 into Kunstmaan:master Jun 11, 2019
@acrobat acrobat deleted the article-bundle-code-improvements branch June 11, 2019 15:24
acrobat added a commit that referenced this pull request Jul 5, 2019
@acrobat
Merge branch 'master' into l10n_master
f0c37fb 
* master: (59 commits)
  Update changelog for 5.3.2 release
  [AllBundles] Generate frontend assets before release
  [AdminBundle] added support for anchor tags in transform and reverseTransform methods of MediaTokenTransformer (#2506)
  bug/missing-form-error-translations (#2503)
  [TranslatorBundle] Restored missing service alias for translator datacollector (#2502)
  [FixtureBundle] Inject the User Entity class name so the correct Repository can be used (#2500)
  [AllBundles] Upgrade jquery to fix security warning (#2497)
  [GeneratorBundle] Added missing import in admin js task (#2510)
  [AdminBundle] Add string return typehint to be compatible with symfony 4.3 (#2493)
  [AdminListBundle] Code improvement found by static code analysis (#2467)
  [ArticleBundle] Code improvement found by static code analysis (#2468)
  [MediaBundle] Code improvement found by static code analysis (#2469)
  [NodeBundle] Code improvement found by static code analysis (#2470)
  [PagePartBundle] Code improvement found by static code analysis (#2471)
  [NodeSearchBundle] Code improvement found by static code analysis (#2487)
  [LeadGenerationBundle] Code improvement found by static code analysis (#2488)
  [FormBundle] Code improvement found by static code analysis (#2489)
  [DashboardBundle] Code improvement found by static code analysis (#2490)
  [MenuBundle] Code improvement found by static code analysis (#2473)
  [TranslatorBundle] Remove useless loop that doesn't loop (#2474)
  ...
lkeijmel pushed a commit to lkeijmel/KunstmaanBundlesCMS that referenced this pull request Jul 31, 2019
@acrobat
[ArticleBundle] Code improvement found by static code analysis (Kunst…
9f87f88 
…maan#2468)
dbeerten pushed a commit to dbeerten/KunstmaanBundlesCMS that referenced this pull request Nov 6, 2019
@acrobat @dbeerten
[ArticleBundle] Code improvement found by static code analysis (Kunst…
d4ff4b7 
…maan#2468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devolicious Devolicious Devolicious approved these changes

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Priority: Normal Target audience: Developers Type: Improvement
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acrobat @Devolicious @ProfessorKuma