Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeneratorBundle] Added missing import in admin js task #2510

Merged
merged 1 commit into from Jul 3, 2019

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Jul 2, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

#2462 was missing an import for the path var

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@Devolicious Devolicious merged commit e222253 into Kunstmaan:5.3 Jul 3, 2019
acrobat added a commit that referenced this pull request Jul 3, 2019
* 5.3:
  Update changelog for 5.3.2 release
  [AllBundles] Generate frontend assets before release
  bug/missing-form-error-translations (#2503)
  [TranslatorBundle] Restored missing service alias for translator datacollector (#2502)
  [FixtureBundle] Inject the User Entity class name so the correct Repository can be used (#2500)
  [AllBundles] Upgrade jquery to fix security warning (#2497)
  [GeneratorBundle] Added missing import in admin js task (#2510)
  [AdminBundle] Add string return typehint to be compatible with symfony 4.3 (#2493)
@acrobat acrobat deleted the missing-import-admin-js branch July 3, 2019 13:06
acrobat added a commit that referenced this pull request Jul 5, 2019
* master: (59 commits)
  Update changelog for 5.3.2 release
  [AllBundles] Generate frontend assets before release
  [AdminBundle] added support for anchor tags in transform and reverseTransform methods of MediaTokenTransformer (#2506)
  bug/missing-form-error-translations (#2503)
  [TranslatorBundle] Restored missing service alias for translator datacollector (#2502)
  [FixtureBundle] Inject the User Entity class name so the correct Repository can be used (#2500)
  [AllBundles] Upgrade jquery to fix security warning (#2497)
  [GeneratorBundle] Added missing import in admin js task (#2510)
  [AdminBundle] Add string return typehint to be compatible with symfony 4.3 (#2493)
  [AdminListBundle] Code improvement found by static code analysis (#2467)
  [ArticleBundle] Code improvement found by static code analysis (#2468)
  [MediaBundle] Code improvement found by static code analysis (#2469)
  [NodeBundle] Code improvement found by static code analysis (#2470)
  [PagePartBundle] Code improvement found by static code analysis (#2471)
  [NodeSearchBundle] Code improvement found by static code analysis (#2487)
  [LeadGenerationBundle] Code improvement found by static code analysis (#2488)
  [FormBundle] Code improvement found by static code analysis (#2489)
  [DashboardBundle] Code improvement found by static code analysis (#2490)
  [MenuBundle] Code improvement found by static code analysis (#2473)
  [TranslatorBundle] Remove useless loop that doesn't loop (#2474)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants