Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MediaBundle] Fix php 7.4 incompatibility #2671

Merged
merged 1 commit into from
May 6, 2020
Merged

[MediaBundle] Fix php 7.4 incompatibility #2671

merged 1 commit into from
May 6, 2020

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented May 5, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #2667

@igst Can you check if this fixes the error you have?

@acrobat acrobat added this to the 5.4.5 milestone May 5, 2020
ProfessorKuma
ProfessorKuma previously requested changes May 5, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • It seems that you should have submitted to the latest minor branch.

@acrobat acrobat linked an issue May 5, 2020 that may be closed by this pull request
Error on loading DefaultSiteFixtures #2667
Closed
@acrobat acrobat mentioned this pull request May 5, 2020
Closed
@igst
Copy link
Contributor

igst commented May 6, 2020

Hi @acrobat,

thanks, yes, its fixed!

@acrobat acrobat force-pushed the fix-php74-incompatibility branch from 74b107c to c8798ff Compare May 6, 2020 19:16
@acrobat acrobat dismissed ProfessorKuma’s stale review May 6, 2020 19:32

Ok, php 7.4 support was added in v5.4

@acrobat acrobat merged commit c9ebce9 into Kunstmaan:5.4 May 6, 2020
@acrobat acrobat deleted the fix-php74-incompatibility branch May 6, 2020 19:33
@OskarStark
Copy link
Contributor

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@ProfessorKuma ProfessorKuma ProfessorKuma left review comments

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
5.4.5
Development

Successfully merging this pull request may close these issues.

Error on loading DefaultSiteFixtures
4 participants
@acrobat @igst @OskarStark @ProfessorKuma