Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeneratorBundle] Use https by default to avoid any mixed content errors #2684

Merged
merged 1 commit into from
Jun 3, 2020
Merged

[GeneratorBundle] Use https by default to avoid any mixed content errors #2684

merged 1 commit into from
Jun 3, 2020

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented May 29, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

@acrobat acrobat added this to the 5.4.6 milestone May 29, 2020
ProfessorKuma
ProfessorKuma approved these changes May 29, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat merged commit fa31144 into Kunstmaan:5.4 Jun 3, 2020
@acrobat acrobat deleted the fix-http-url-webfonts branch June 3, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Numkil Numkil Numkil approved these changes

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Bugfix
Projects
None yet
Milestone
5.4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@acrobat @Numkil @ProfessorKuma