Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AllBundles] Rework controller for symfony 5 compatibility #2962

Merged
merged 1 commit into from
Oct 5, 2021
Merged

[AllBundles] Rework controller for symfony 5 compatibility #2962

merged 1 commit into from
Oct 5, 2021

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Oct 4, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

@acrobat acrobat added this to the 6.1.0 milestone Oct 4, 2021
@acrobat acrobat added this to In progress in Symfony 5 support via automation Oct 4, 2021
ProfessorKuma
ProfessorKuma suggested changes Oct 4, 2021
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • It seems that you should have submitted to master.

@acrobat acrobat force-pushed the rework-controllers branch 4 times, most recently from 5771151 to 194a623 Compare October 5, 2021 10:06
@acrobat acrobat merged commit b807a20 into Kunstmaan:6.x Oct 5, 2021
Symfony 5 support automation moved this from In progress to Done Oct 5, 2021
@acrobat acrobat deleted the rework-controllers branch October 5, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma requested changes

Assignees
No one assigned
Labels
Type: Feature
Projects
No open projects
Symfony 5 support
  
Done
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acrobat @ProfessorKuma