[SeoBundle] Fix hanging flash message, it will now disappear after save #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denbatte
changed the title
| @@ -68,6 +51,11 @@ public function robotsSettingsAction(Request $request) | |||
| } | |||
| } | |||
|
|
|||
| if ($robot->getRobotsTxt() === $default) { | |||
There was a problem hiding this comment.
I think this is not the correct check. When someone saves the default text, there is an entry in the database, but $robot->getRobotsTxt() === $defaultis still true...
There was a problem hiding this comment.
you should show the warning only when the value is null, and if the value is null, the default should be used in the "front"
|
@denbatte what is the status of this pr? |
|
@roderik 👍 |
roderik
pushed a commit
that referenced
this pull request
Apr 27, 2015
[SeoBundle] Fix hanging flash message, it will now disappear after save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flash message did not go away after save.
Refactored the code to solve this issue