[SeoBundle] Fixed issue that OG image can not be deleted. #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bureaublauwgeel
commented
May 26, 2015
bureaublauwgeel
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | 428 |
code formatting fix error minheight undefined
roderik
changed the title
[AdminListBundle] Fixes adminlist filters
| @@ -350,7 +350,7 @@ public function getOgDescription() | |||
| * | |||
| * @return Seo | |||
| */ | |||
| public function setOgImage(Media $ogImage) | |||
There was a problem hiding this comment.
Removing the type is not the fix for a null-exception. Can you change this to "Media $ogImage = null" ?
added slugifier service to fixtures add slugifier service to NodeBundle updated slugifier tests inject slugifier into utilitiesTwigExtension twigExtension now works with the slugifier service removed @Covers in slugifierTest implemented slugifierInterface
…config-support [AdminBundle] Added option to use a custom CKEditor config.js file
[GeneratorBundle] Refactor pagepart media validation
[AdminBundle] Added an option to change the backend site name to a logo
[AdminBundle,GeneratorBundle,NodeBundle,UtilitiesBundle] Change slugifier into service
[AdminBundle] Fix drag and drop sub entities
…l/KunstmaanBundlesCMS into feature/issue_428 * 'feature/issue_428' of https://github.com/bureaublauwgeel/KunstmaanBundlesCMS: Fixed issue that OG image can not be deleted.
wimvds
added a commit
to wimvds/KunstmaanBundlesCMS
that referenced
this pull request
May 28, 2015
|
Replaced with #452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.