[AdminBundle] Make AdminLocaleListener also update locale on subrequests #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's assume it works until someone yells at me for breaking it :) |
roderik
pushed a commit
that referenced
this pull request
Jun 18, 2015
…r-symfony-2.6 Make AdminLocaleListener also update locale on subrequests
roderik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Symfony 2.6 it seems to be necessary to also update the locale on subrequests. This becomes apparent when viewing a backend pag with a subrequest while the request locale (by virtue of the default locale) is not equal to an admin locale of a backend user. In my case I had my default locale set to Dutch (nl) and the backend locale set to English (en). This resulted in the dashboard page using Dutch translations, while the rest of the backend uses English translations.
Apparently this is caused by a refactor of the TranslatorListener in Symfony 2.6, which also acts on subrequests. I'm not certain if checking for a subrequest is still needed in Symfony 2.5, if so we need to look for another solution.