Add check for presence of security token in AdminLocaleListener #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix situations where there is not security context, such as during 404 exceptions.
roderik
pushed a commit
that referenced
this pull request
Jul 8, 2015
…r-security-context Add check for presence of security token in AdminLocaleListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoops, this is a fix for my previous pull request: #499
I will now yell at myself for breaking it :(
Apparently the previous check for subrequests protected against executing the code in AdminLocaleListener in case an exception needs to be handled, most notably a 404. Removing this check results in 404s no longer being handled correctly, as can be seen on your own demosite: http://demo.bundles.kunstmaan.be/en/doesnotexist
I've added an explicit check for the security context to handle this situation. Apologies for breaking this in the first place.