Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemReducer doesn't support retrieve #10

Closed
bhoomit opened this issue Mar 26, 2016 · 4 comments
Closed

ItemReducer doesn't support retrieve #10

bhoomit opened this issue Mar 26, 2016 · 4 comments

Comments

@bhoomit
Copy link
Contributor

bhoomit commented Mar 26, 2016

I don't see an "else if" condition for "action.type === this.actionTypes.retrieve" for retrive actions.

@mallison
Copy link
Contributor

Oh, good point! The action should be available so adding retrieve to the reducer, following the pattern of the other actions, should work ok. (Just noticed the _success, _failure code could probably be pulled out to a function so you don't have to type out the three cases for each action manually).

@mallison
Copy link
Contributor

I've added retrieve to the reducer with some basic tests.

@bhoomit
Copy link
Contributor Author

bhoomit commented Mar 29, 2016

@mallison cool, it works. Thanks :)

@mallison
Copy link
Contributor

No problem!
On 29 Mar 2016 8:12 a.m., "Bhoomit" notifications@github.com wrote:

@mallison https://github.com/mallison cool, it works. Thanks :)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10 (comment)

@bhoomit bhoomit closed this as completed Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants