Disabled no synth card #1355
Merged
Disabled no synth card #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LeifuChen
force-pushed
the
fix/exchange-onboard-message
branch
from
38e48d7
to
c8b6877
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
platschi
approved these changes
Sep 5, 2022
platschi
pushed a commit
that referenced
this pull request
Sep 5, 2022
* Disabled no synth card * Added ETH approval * Limit the liquidity source * Update the token address * Fixed the lint error and update the token address * Fix the swap pricing display
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You have no open positions. Open a position now:in exchange page when users have no synthetic assets in their wallet, which is not fit as exchange page supports erc20 swap right now.2.ETH => sUSD throws the error after the change in #1300.
The root cause is that 1inch and coingecko use the different token addresses to represent ETH.
Related issue
Motivation and Context
Improve the UX with newcomers who have no synthetic assets.
How Has This Been Tested?
No insufficient balanceScreenshots (if appropriate):