-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency of type conversions with the table in README #27
Comments
Are you up for submitting a patch for readme?
…On Mon, 9 Apr 2018, 11:55 pm Shang Linwei, ***@***.***> wrote:
Some entries in the type conversion table in README are wrong:
kdb/q r (wrong) r (correct)
timespan character difftime
time difftime integer
Correct means what actually happen in rkdb.
Please check whether the README or the code should be fixed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#27>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA3BvYHp0YgV0wmZe9HADYJLULqHLktks5tm4RjgaJpZM4TMybq>
.
|
I'm not sure whether we should just correct readme. |
Hi @sv , Are you considering this issue? Do you think it is better to change the way to deal with time instead of modifying readme? I would like to fix it and make a pull request. But I want to have a consensus on it before start to working on it. And could please to give some instructions on how to set up the develop tools for this project? I notice that you put the source codes into several separate files like |
thanks for looking into submitting pull request. for dev environment, i just use RStudio with devtools package and rarely need to move functions between files. Agree that common.c/base.c/sexp2k.c is a bit misleading and should be just header files that get imported in rkdb.c. We can cleanup this as we go Let me know if you need any help with raising PR |
Some entries in the type conversion table in README are wrong:
Correct means what actually happen in rkdb.
Please check whether the README or the code should be fixed.
The text was updated successfully, but these errors were encountered: