Skip to content
This repository has been archived by the owner on Nov 12, 2022. It is now read-only.

refactor: run poetry doit and update #23

Merged
merged 3 commits into from
Dec 9, 2021
Merged

refactor: run poetry doit and update #23

merged 3 commits into from
Dec 9, 2021

Conversation

KyleKing
Copy link
Owner

@KyleKing KyleKing commented Dec 9, 2021

No description provided.

@KyleKing KyleKing self-assigned this Dec 9, 2021
@KyleKing KyleKing changed the title build: run poetry doit and update refactor: run poetry doit and update Dec 9, 2021
build: run poetry doit and update (Sourcery refactored)
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 9, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.03%.

Quality metrics Before After Change
Complexity 1.83 ⭐ 1.81 ⭐ -0.02 👍
Method Length 54.44 ⭐ 54.41 ⭐ -0.03 👍
Working memory 8.10 🙂 8.10 🙂 0.00
Quality 74.47% 🙂 74.50% 🙂 0.03% 👍
Other metrics Before After Change
Lines 5186 5460 274
Changed files Quality Before Quality After Quality Change
_try_tabulator.py 87.25% ⭐ 87.25% ⭐ 0.00%
dodo.py 79.01% ⭐ 79.01% ⭐ 0.00%
noxfile.py 95.02% ⭐ 95.02% ⭐ 0.00%
.dash_tutorials/02-dash-core-components.py 94.37% ⭐ 94.37% ⭐ 0.00%
.dash_tutorials/08_px-charts.py 39.97% 😞 39.97% 😞 0.00%
dash_charts/app_px.py 66.78% 🙂 66.78% 🙂 0.00%
dash_charts/components.py 87.16% ⭐ 87.16% ⭐ 0.00%
dash_charts/coordinate_chart.py 74.19% 🙂 74.19% 🙂 0.00%
dash_charts/datatable.py 71.58% 🙂 71.58% 🙂 0.00%
dash_charts/gantt_chart.py 66.83% 🙂 66.83% 🙂 0.00%
dash_charts/modules_datatable.py 73.49% 🙂 73.49% 🙂 0.00%
dash_charts/modules_upload.py 76.41% ⭐ 76.41% ⭐ 0.00%
dash_charts/pareto_chart.py 75.55% ⭐ 75.55% ⭐ 0.00%
dash_charts/scatter_line_charts.py 58.81% 🙂 58.81% 🙂 0.00%
dash_charts/time_vis_chart.py 66.75% 🙂 66.75% 🙂 0.00%
dash_charts/utils_app_with_navigation.py 77.75% ⭐ 77.75% ⭐ 0.00%
dash_charts/utils_callbacks.py 75.94% ⭐ 76.70% ⭐ 0.76% 👍
dash_charts/utils_data.py 88.85% ⭐ 88.85% ⭐ 0.00%
dash_charts/utils_helpers.py 85.48% ⭐ 85.48% ⭐ 0.00%
scripts/plot_stale_dependencies.py 90.56% ⭐ 90.56% ⭐ 0.00%
tests/test_example_snippets.py 95.16% ⭐ 95.16% ⭐ 0.00%
tests/test_utils_json_cache.py 83.99% ⭐ 83.99% ⭐ 0.00%
tests/examples/ex_coordinate_chart.py 70.52% 🙂 70.52% 🙂 0.00%
tests/examples/ex_fitted_chart.py 91.98% ⭐ 91.98% ⭐ 0.00%
tests/examples/ex_gantt_chart.py 93.60% ⭐ 93.60% ⭐ 0.00%
tests/examples/ex_marginal_chart.py 90.41% ⭐ 90.41% ⭐ 0.00%
tests/examples/ex_modules_upload.py 89.06% ⭐ 89.06% ⭐ 0.00%
tests/examples/ex_multi_page.py 91.56% ⭐ 91.56% ⭐ 0.00%
tests/examples/ex_pareto_chart.py 88.80% ⭐ 88.80% ⭐ 0.00%
tests/examples/ex_rolling_chart.py 75.08% ⭐ 75.08% ⭐ 0.00%
tests/examples/ex_sqlite_realtime.py 73.86% 🙂 73.86% 🙂 0.00%
tests/examples/ex_style_bootstrap.py 89.73% ⭐ 89.73% ⭐ 0.00%
tests/examples/ex_style_bulma.py 91.82% ⭐ 91.82% ⭐ 0.00%
tests/examples/ex_tabs.py 86.57% ⭐ 86.57% ⭐ 0.00%
tests/examples/ex_time_vis_chart.py 84.58% ⭐ 84.58% ⭐ 0.00%
tests/examples/ex_utils_static.py 64.40% 🙂 64.40% 🙂 0.00%
tests/examples/readme.py 93.03% ⭐ 93.03% ⭐ 0.00%
wip/basketball.py 49.99% 😞 49.96% 😞 -0.03% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
wip/basketball.py draw_plotly_court 4 ⭐ 685 ⛔ 19 ⛔ 34.21% 😞 Try splitting into smaller methods. Extract out complex expressions
dash_charts/modules_datatable.py ModuleFilteredTable.register_show_query 8 ⭐ 171 😞 12 😞 49.36% 😞 Try splitting into smaller methods. Extract out complex expressions
dash_charts/time_vis_chart.py TimeVisChart._create_event 2 ⭐ 144 😞 18 ⛔ 50.71% 🙂 Try splitting into smaller methods. Extract out complex expressions
dash_charts/datatable.py split_filter_part 17 🙂 100 🙂 11 😞 51.44% 🙂 Extract out complex expressions
dash_charts/coordinate_chart.py CoordinateChart.create_traces 2 ⭐ 124 😞 20 ⛔ 51.61% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@KyleKing KyleKing merged commit 26d8ccd into main Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant