Skip to content
This repository has been archived by the owner on Nov 12, 2022. It is now read-only.

build: run poetry doit and update (Sourcery refactored) #24

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Dec 9, 2021

Pull Request #23 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the development branch, then run:

git fetch origin sourcery/development
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from KyleKing December 9, 2021 01:03
dash_charts/utils_callbacks.py Show resolved Hide resolved
wip/basketball.py Show resolved Hide resolved
@sourcery-ai
Copy link
Author

sourcery-ai bot commented Dec 9, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.29%.

Quality metrics Before After Change
Complexity 2.21 ⭐ 1.90 ⭐ -0.31 👍
Method Length 160.27 😞 159.45 😞 -0.82 👍
Working memory 14.15 😞 14.41 😞 0.26 👎
Quality 56.64% 🙂 56.35% 🙂 -0.29% 👎
Other metrics Before After Change
Lines 488 483 -5
Changed files Quality Before Quality After Quality Change
dash_charts/utils_callbacks.py 75.94% ⭐ 76.70% ⭐ 0.76% 👍
wip/basketball.py 49.99% 😞 49.96% 😞 -0.03% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
wip/basketball.py draw_plotly_court 4 ⭐ 685 ⛔ 19 ⛔ 34.21% 😞 Try splitting into smaller methods. Extract out complex expressions
wip/basketball.py draw_plotly_court.ellipse_arc 2 ⭐ 91 🙂 15 😞 60.39% 🙂 Extract out complex expressions
dash_charts/utils_callbacks.py map_args 5 ⭐ 102 🙂 10 😞 63.77% 🙂 Extract out complex expressions
wip/basketball.py filter_hexbins 4 ⭐ 66 🙂 10 😞 69.99% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@KyleKing KyleKing merged commit 6d4c850 into development Dec 9, 2021
@KyleKing KyleKing deleted the sourcery/development branch December 9, 2021 01:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant