Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer crypto:strong_rand_bytes/1 #15

Merged
merged 1 commit into from
Nov 25, 2016
Merged

prefer crypto:strong_rand_bytes/1 #15

merged 1 commit into from
Nov 25, 2016

Conversation

getong
Copy link

@getong getong commented Nov 24, 2016

I just see the cowlib use the strong_rand_bytes/1 to replace the rand_bytes/1.
So I add the code here, see
Fix #39

@Licenser Licenser merged commit 9bbcfcb into Kyorai:fifo-0.9.0 Nov 25, 2016
@Licenser
Copy link
Member

merged and reverted again strong bytes can throw exceptions.

@Licenser
Copy link
Member

Mate I appreciate your contributions and enthusiasm but I must ask you to be a bit more diligent before opening a PR. It's neither fun for you to have your changes reverted nor is it fun for me to nit pick over every change and investigate every function.

If you read the documentation of strong_random_bytes it will throw errors of the random source is out of data this can be quite fatal and doesn't sound like a very great idea.

@getong getong deleted the strong_rand_bytes branch November 25, 2016 05:15
@getong
Copy link
Author

getong commented Nov 25, 2016

Sorry. I had read the doc before I made a PR, and I know to add the catch before the function, but I think it is worth doing it. A little change must be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants