Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gson serializer does not properly handle arrays #26

Closed
lucko opened this issue Jan 21, 2019 · 0 comments
Closed

Gson serializer does not properly handle arrays #26

lucko opened this issue Jan 21, 2019 · 0 comments
Assignees
@lucko

Comments

@lucko
Copy link
Member

lucko commented Jan 21, 2019

https://github.com/KyoriPowered/text/blob/957d07e0faeef86893efe420f8e549b48efca335/serializer-gson/src/main/java/net/kyori/text/serializer/gson/GsonComponentSerializer.java#L80-L90

The call to parent.append(...) does not actually modify parent, as components are immutable! It returns the result.
@lucko lucko self-assigned this Jan 21, 2019
@lucko lucko closed this as completed in 7b46500 Jan 21, 2019
kashike pushed a commit that referenced this issue Jan 21, 2019
@lucko @kashike
Fix Gson serializer array handling (fixes #26)
2c03d85
kashike pushed a commit that referenced this issue Jan 21, 2019
@lucko @kashike
Fix Gson serializer array handling (fixes #26)
9f2070d
zml2008 pushed a commit that referenced this issue Dec 7, 2021
@MiniDigger
Treat invalid close tags as strings, closes #26
2630d1f 
Signed-off-by: MiniDigger <admin@minidigger.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucko lucko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucko