Make fallback locale configurable #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
requested changes
Sep 28, 2020
api/src/main/java/net/kyori/adventure/translation/TranslationRegistryImpl.java
Outdated
Show resolved
Hide resolved
lucko
force-pushed
the
fix/default-locale
branch
4 times, most recently
from
41c58d5
to
b449692
Compare
lucko
force-pushed
the
fix/default-locale
branch
from
b449692
to
02ca645
Compare
|
I don't think this will work with a global translator -- if 1 plugin changes the default, it's likely to break another plugin that depends on another default. |
|
@Electroid Yep, I agree - I made another PR #167 to resolve this. |
zml2008
pushed a commit
that referenced
this pull request
Oct 11, 2020
kashike
pushed a commit
that referenced
this pull request
Oct 12, 2020
zml2008
pushed a commit
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.