Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some issues with translatable component fallback #885

Merged
merged 2 commits into from Mar 24, 2023

Conversation

LemonCaramel
Copy link
Contributor

This PR fixes some issues with translatable component fallback.

commit 8b3cd4a:

  • BEFORE
    image
  • AFTER
    image

commit e8105f4:

  • BEFORE (same as above image)
  • AFTER
    image

@kashike kashike self-assigned this Mar 24, 2023
@kashike kashike added this to the 4.14.0 milestone Mar 24, 2023
@kashike kashike modified the milestones: 4.14.0, 4.13.1 Mar 24, 2023
@kashike kashike enabled auto-merge March 24, 2023 02:54
@kashike kashike added this pull request to the merge queue Mar 24, 2023
Merged via the queue into KyoriPowered:main/4 with commit fbe91f9 Mar 24, 2023
2 checks passed
@LemonCaramel LemonCaramel deleted the fix/translate-fallback branch March 24, 2023 03:11
rainbowdashlabs pushed a commit to eldoriarpg/survivalschematicbrush that referenced this pull request Apr 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[net.kyori:adventure-text-minimessage](https://togithub.com/KyoriPowered/adventure)
| `4.13.0` -> `4.13.1` |
[![age](https://badges.renovateapi.com/packages/maven/net.kyori:adventure-text-minimessage/4.13.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/maven/net.kyori:adventure-text-minimessage/4.13.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/maven/net.kyori:adventure-text-minimessage/4.13.1/compatibility-slim/4.13.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/maven/net.kyori:adventure-text-minimessage/4.13.1/confidence-slim/4.13.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>KyoriPowered/adventure</summary>

###
[`v4.13.1`](https://togithub.com/KyoriPowered/adventure/releases/tag/v4.13.1):
🌏 Adventure 4.13.1

Adventure 4.13.1 is a bugfix release with fixes focused around
MiniMessage and translatable component fallbacks. We recommend updating
at your earliest convenience.

#### Fixes 🐛

- fix some issues with translatable component fallback by
[@&#8203;LemonCaramel](https://togithub.com/LemonCaramel) in
[KyoriPowered/adventure#885
- ComponentFlattenerImpl: translatable components check fallback first
by [@&#8203;Camotoy](https://togithub.com/Camotoy) in
[KyoriPowered/adventure#895
- fix(text-minimessage): Correctly handle phase and multi-colour
gradients by [@&#8203;zml2008](https://togithub.com/zml2008) in
[KyoriPowered/adventure#896

#### New Contributors

- [@&#8203;LemonCaramel](https://togithub.com/LemonCaramel) made their
first contribution in
[KyoriPowered/adventure#885
- [@&#8203;Camotoy](https://togithub.com/Camotoy) made their first
contribution in
[KyoriPowered/adventure#895

**Full Changelog**:
KyoriPowered/adventure@v4.13.0...v4.13.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/eldoriarpg/survivalschematicbrush).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants