Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropbox - access to subfolder only #24

Closed
vovodroid opened this issue Mar 11, 2016 · 13 comments
Closed

Dropbox - access to subfolder only #24

vovodroid opened this issue Mar 11, 2016 · 13 comments

Comments

@vovodroid
Copy link

Currently plugin asks permission to the whole Dropbox account. From security reasons it would be much better to get permission to subfolder only, e.g. "KeeAnywhere".

@Kyrodan
Copy link
Owner

Kyrodan commented Mar 14, 2016

@vovodroid:
Please describe, what is the concrete security advantage with the folder method?

I see that both options are possible via Dropbox-API (https://www.dropbox.com/developers/reference/developer-guide#app-permissions).

I see some glitches:

  • Requirement of more documentation and/or more configuration options. Both lead to more complexity which I don't really want. The plugin simply should work (even for novices).
  • The folder name is not configurable, so it's always the plugins name (in this case "KeeAnywhere")
  • Can other Apps (with full permission) access this folder? Thsi is needed for sharing with other (mobile) Apps like KeePass2Android. What if KeePass2Android also only allows access to "his" folder in future?

@vovodroid
Copy link
Author

what is the concrete security advantage with the folder method

Assuming some malware attacked computer and stole DropBox auth tokens it will get access to whole DropBox account.

and/or more configuration options

I guess hardcoded name can be used to keep it simple.

Can other Apps (with full permission) access this folder

I believe it can.

@Kyrodan
Copy link
Owner

Kyrodan commented Mar 14, 2016

I see your point but I'm unsure about that. Currently I'm not willing to change something short-term: I won't restrict the plugin in this point. Maybe we find a better solution. I leave this issue open to collect some more opinions on that.

Here are my thoughts:
Isn't it a very theoretical scenario? Beneath the Auth Token you also need the App Key to get it to work (to be fair: the app key is not a real secret). And: your password database is maybe a more interesting target than your "other documents"? Wouldn't it be easyer to steal the Dropbox Client Auth Token than the token from this plugin? Wouldn't it be easyer to hack KeePass itself? Do you really store secrets like "other documents" unsecured (without any other encryption) in a cloud storage provider?

For me, cloud storage providers should be considered unsecure by default and the user is responsive for additionally protecting his data.

Btw: I can't change the app permission in Dropbox Developer Center at this time ... I need to create a new App Key (or revoke the current one).

@vovodroid
Copy link
Author

your password database is maybe a more interesting target than your "other documents"

Sure. But it's not stored on computer.
And if computer is stolen, thief can extract DropBox credentials (and there is option to store them in KeePass xml file), and nevertheless a more bit of security never harms )

@namtab00
Copy link

+1 for App folder permissions only

@Kyrodan
Copy link
Owner

Kyrodan commented Jun 20, 2016

Hi @vovodroid, @namtab00, @0Derece,

I'd like to solve this by creating a "new" Provider "Dropbox-Secure" (URL-Schema "dropboxs") with folder permission only. This means I created a second App in Dropbox - one with full permission and one with app folder permission.

You can now register a new account either "Dropbox" or "Dropbox-Secure" (or mix both if you like).
See screenshot:
2016-06-20 15_49_11-keepass

What do you think? Does this solve this issue for you all?

@Kyrodan
Copy link
Owner

Kyrodan commented Jun 20, 2016

@vovodroid
Copy link
Author

vovodroid commented Jun 20, 2016

What do you think?

I think it's great, working like a charm!

What about other providers, like Google Drive? Does it have the same issue?

@Kyrodan
Copy link
Owner

Kyrodan commented Jun 20, 2016

I haven't checked other providers so far. I just wanted to check out,
whether this idea is a suitable and accepted solution.

Vovodroid notifications@github.com schrieb am Mo., 20. Juni 2016, 16:28:

What do you think?
I think it's great, working like a charm!

What about other providers, like Google Drive? Does it have the same issue?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#24 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAVraitO2oeB67in7iEYPLFiwsOqIggzks5qNqOmgaJpZM4HulKL
.

@vovodroid
Copy link
Author

whether this idea is a suitable and accepted solution.

Sure it is!

@onuruslu
Copy link

What do you think? Does this solve this issue for you all?

Thank you @Kyrodan... It's perfect...

@Kyrodan
Copy link
Owner

Kyrodan commented Jun 21, 2016

Checked this for the other providers:

@Kyrodan
Copy link
Owner

Kyrodan commented Jun 22, 2016

@vovodroid @namtab00 @0Derece,

I renamed "Dropbox-Secure" to "Dropbox-Restricted". I think this is a more intuitive name. You all need to re-add your accounts in final 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants