Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious name for the Game Class #7

Closed
BharatSahlot opened this issue Mar 14, 2023 · 0 comments · Fixed by #24
Closed

Mysterious name for the Game Class #7

BharatSahlot opened this issue Mar 14, 2023 · 0 comments · Fixed by #24
Assignees

Comments

@BharatSahlot
Copy link
Collaborator

BharatSahlot commented Mar 14, 2023

The game class only prints the colors filled with other classes. It does nothing else. All the other functionality is in game.py.

Code Smell: Lazy class/freeloader and Mysterious name

Suggested Refractor

  • Rename this class to something like Renderer or,
  • Move actual game logic to this class, making the game.py just create an instance of Game and call its play() or run() function
@BharatSahlot BharatSahlot self-assigned this Mar 20, 2023
BharatSahlot added a commit that referenced this issue Mar 21, 2023
* (#7): start game class refractor

* fix input and rendering

* move check victory, defeat and nariKey logic to gameclass

* all game logic moved to gameclass

* complete refactor

* add spawn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant