-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotations/enforce unicity #413
Conversation
I am also unsatisfied about the ChildProject/ChildProject/utils.py Line 180 in 6f6474f
eval() .
EDIT: changed to use eval, looks alright to me this way :) |
This change also leads to annotations always being sorted by 'imported_at' values. However, a lot of lines have the same value for that, leading to annotations.csv being changed in the order inconsistently by every importation done. So And maybe add a test for that sorting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. But I see a merge conflict which probably need to be resolved.
The purpose of the PR is to enforce that:
To achieve this, all the functions that interact with annotations.csv must make sure before writing to it that those cases don't exist,
this is especially relevant for importations that now will fail for every row that does not satisfy those conditions.
Previously, the errors encountered during importation would find themselves recorded into annotations.csv. I felt like this could be troublesome as the file is intended as a record of indexed annotation and should not serve as a logfile. My take was to output all the errors to a separate csv in extra but not too sure about this solution