Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ranking assistant replies bug - a reply is too big #1685

Closed
nadavMihov opened this issue Feb 17, 2023 · 3 comments · Fixed by #1771
Closed

Ranking assistant replies bug - a reply is too big #1685

nadavMihov opened this issue Feb 17, 2023 · 3 comments · Fixed by #1771
Assignees
@owenduncansnobel
Labels
bug Something isn't working website
Milestone
Web Code Cleanup

Comments

@nadavMihov
Copy link

Hello,
I was ranking some assistant reply when I came across a reply so wide it wouln't let me place it at the top if it was in the bottom before (and vice versa).
image
This only happens if the reply is first or last, If it's in the middle I can move it anywhere.
@nadavMihov nadavMihov changed the title Ranking assistant replies bug - a raply is too big Ranking assistant replies bug - a reply is too big Feb 17, 2023
@olliestanley olliestanley added bug Something isn't working website labels Feb 17, 2023
@JohannesGaessler
Copy link

Workaround: I was always able to move the smaller messages instead of the larger one.

@andreaskoepf andreaskoepf added this to the Web Code Cleanup milestone Feb 20, 2023
@owenduncansnobel
Copy link
Contributor

I am taking a stab at this

@owenduncansnobel
Copy link
Contributor

@andreaskoepf I figured out what was causing it. The Sortable items were bound to stay in the parent container when dragged/sorted. If I disable it you can see it works. Let me know if disabling it is fine the only "issue" is if someone drags it to the top of the screen it just looks slightly ugly until you let go and it snaps back.

Screen.Recording.2023-02-20.at.12.48.34.PM.mov

owenduncansnobel pushed a commit to owenduncansnobel/Open-Assistant that referenced this issue Feb 20, 2023
@owen-duncan-snobel
fix for "LAION-AI#1685"
d40a6b3
@AbdBarho AbdBarho mentioned this issue Feb 20, 2023
Merged
andreaskoepf pushed a commit that referenced this issue Feb 20, 2023
@owenduncansnobel
Allow SortableElements to move out of the parent element (#1771)
ad8a6b5 
Fix #1685 the Sortable component for "Ranking assistant replies bug - a
reply is too big"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owenduncansnobel owenduncansnobel

Labels
bug Something isn't working website
Projects
Open-Assistant
Archived in project
Milestone
Web Code Cleanup
Development

Successfully merging a pull request may close this issue.

Allow SortableElements to move out of the parent element owenduncansnobel/Open-Assistant
6 participants
@olliestanley @andreaskoepf @JohannesGaessler @owenduncansnobel @nadavMihov and others