Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup all eslint warnings in the website #193

Closed
fozziethebeat opened this issue Dec 31, 2022 · 4 comments · Fixed by #199
Closed

Cleanup all eslint warnings in the website #193

fozziethebeat opened this issue Dec 31, 2022 · 4 comments · Fixed by #199
Assignees
@croumegous
Labels
good first issue Good issue for project newcomers website

Comments

@fozziethebeat
Copy link
Collaborator

Running npm run build reveals a large number of small warnings. We should do a full pass over and clean them up.
@fozziethebeat fozziethebeat added website good first issue Good issue for project newcomers labels Dec 31, 2022
@AbdBarho
Copy link
Collaborator

npx eslint --fix unfortunately does not solve the problem.

Maybe we could integrate some tool that does this for us automatically.

https://github.com/trivago/prettier-plugin-sort-imports

@croumegous
Copy link
Collaborator

I'll be happy to work on this cleanup

@AbdBarho
Copy link
Collaborator

@croumegous great, I will assign it to you.

@croumegous
Copy link
Collaborator

PR #199

@yk yk linked a pull request Dec 31, 2022 that will close this issue
Fix linter warnings #199
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@croumegous croumegous

Labels
good first issue Good issue for project newcomers website
Projects
Open-Assistant
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix linter warnings croumegous/Open-Assistant
3 participants
@fozziethebeat @AbdBarho @croumegous