Fix linter warnings #199
Merged
Fix linter warnings #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croumegous
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
croumegous
force-pushed
the
fix-lint-build
branch
from
1f61988
to
ed99295
Compare
AbdBarho
reviewed
Dec 31, 2022
There was a problem hiding this comment.
@croumegous thanks for the contribution!
could you please rebase? easier to review.
With the exception of my comment it looks fine.
website/.eslintrc.json
Outdated
Comment on lines
10
to
12
| "simple-import-sort/exports": "error", | ||
| "@typescript-eslint/no-unused-vars": "off", | ||
| "unused-imports/no-unused-imports": "error", | ||
| "unused-imports/no-unused-vars": [ | ||
| "warn", | ||
| { | ||
| "vars": "all", | ||
| "varsIgnorePattern": "^_", | ||
| "args": "after-used", | ||
| "argsIgnorePattern": "^_" | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
I know that customizing eslint is always very opinionated... imo there is no need for these rules.
I will have to wait for opinions of other team member...
There was a problem hiding this comment.
I've changed it to keep the less rule as possible to make it work:
"unused-imports/no-unused-imports": "warn", //mandatory to automatically remove unused import
"simple-import-sort/imports": "warn", //mandatory to automatically sort import
"simple-import-sort/exports": "warn" //mandatory to automatically sort export
There was a problem hiding this comment.
I think these three small additions look good.
croumegous
force-pushed
the
fix-lint-build
branch
from
ed99295
to
63b7afb
Compare
croumegous
force-pushed
the
fix-lint-build
branch
from
63b7afb
to
ff66c8b
Compare
croumegous
force-pushed
the
fix-lint-build
branch
from
ff66c8b
to
8c79cad
Compare
fozziethebeat
approved these changes
Jan 1, 2023
|
Please fix the merge issues and then I'll re-review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed all warnings in
next build/next lintAdded a new npm command:
npm run fixto run format and lint code.To make review easier I have made 2 commits, the first one adds eslint plugins to automatically handle import sort and unused import.
And a second commit which fixes the remaining warning manually, so this commit is more "opinionated" and needs more attention during the review.
(I have added some
//eslint-disable-next-linefor some part, where it seems to be the best option)(There is a lot of changes so it might create conflicts for other people working on /website)