Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Text Labels in web frontend #42

Closed
yk opened this issue Dec 19, 2022 · 8 comments · Fixed by #189
Closed

Implement Text Labels in web frontend #42

yk opened this issue Dec 19, 2022 · 8 comments · Fixed by #189
Assignees
Labels
feature New feature or request website

Comments

@yk
Copy link
Collaborator

yk commented Dec 19, 2022

Text labels are described in #40 .

Make sure the user can submit those for every post they see.

@yk yk added feature New feature or request website labels Dec 19, 2022
@yk yk added this to the Minimum Viable Prototype milestone Dec 19, 2022
@fozziethebeat
Copy link
Collaborator

This feature is now open for work.

I'll make a web API point to submit labels that complies with the backend change and then document it. Then we can generalize the component in the current rating task and add it to every task.

@BitterKanegul
Copy link
Contributor

Hi @fozziethebeat , @yk , I would love to take this up!

@fozziethebeat
Copy link
Collaborator

Ideally this will make the checklist code in the current grading task a re-usable component that is revealed as a popover (hidden behind a flag icon). Then, when a user has checked one or more tags, they get submitted and associated with the task id.

To be complete, this will require both the UI side and and the web rest end point setup so that the tags are sent to the FastAPI backend.

@BitterKanegul
Copy link
Contributor

One feature that was discussed in #40 was allowing parts of the generated text to be annotated with various labels.

Do you think highlights and selection for the text is a way to go/ convert the text into a set of tags(each word is a tag) and allow the user to click on each?

@yk
Copy link
Collaborator Author

yk commented Dec 27, 2022

I think most text labels don't necessarily make sense to restrict to individual words, so I'd prefer the approach where the user range-selects some text. I think preference should always be given (ui-wise) to putting labels onto an entire post, because being able to map labels not only to text, but to posts inside conversations gives us some extra possibilities to create datasets, but I also think sometimes it's not appropriate to label an entire post, therefore I suggested the ability to annotate this kind of arbitrary text.

@BitterKanegul
Copy link
Contributor

Interesting! I'll try to make it by default select an entire post, and if the user wishes, can change the selection to a substring of the post. Multiple labels on the same post/substring is also possible?

@yk
Copy link
Collaborator Author

yk commented Dec 27, 2022

Interesting! I'll try to make it by default select an entire post, and if the user wishes, can change the selection to a substring of the post. Multiple labels on the same post/substring is also possible?

sounds like it could work :) yes, any label can be assigned a value from 0 to 1 (ideally, for binary labels just use 0 and 1)

@fozziethebeat
Copy link
Collaborator

I would say for the MVP and first PR we should just support text labels to an entire post. After the MVP we can get fancy with sub-post labeling. And we should be able to add multiple tags (i.e. a checkbox) for any given post.

@AbdBarho AbdBarho linked a pull request Dec 31, 2022 that will close this issue
fozziethebeat added a commit that referenced this issue Jan 2, 2023
…eb-frontend

#42 Adding popover to flag text with labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request website
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants