Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing prompt #1274

Merged
merged 10 commits into from Feb 10, 2023
Merged

Writing prompt #1274

merged 10 commits into from Feb 10, 2023

Conversation

fabraz
Copy link
Contributor

@fabraz fabraz commented Feb 6, 2023

This PR deliveries the code used to sample writing prompt dataset, which can be downloaded at https://huggingface.co/datasets/fabraz/writingPromptAug.

@andrewm4894
Copy link
Collaborator

@fabraz thanks!

can you add a readme in the folder and a open in colab button to the notebook.

Idea being someone can quickly scan the readme and then just open the notebook in Google colab even if they want to start playing with it.

https://github.com/LAION-AI/Open-Assistant/tree/main/notebooks/example

@fabraz
Copy link
Contributor Author

fabraz commented Feb 6, 2023

@fabraz thanks!

can you add a readme in the folder and a open in colab button to the notebook.

Idea being someone can quickly scan the readme and then just open the notebook in Google colab even if they want to start playing with it.

https://github.com/LAION-AI/Open-Assistant/tree/main/notebooks/example

@andrewm4894, I just realized that this notebook would be better located under data-augmentation. Do you agree?

@andrewm4894
Copy link
Collaborator

Yep, maybe so. Kinda a lot of stuff ending up under data augmentation since it is very general but makes sense. Am sure some stage down the road we might reorder things in various ways but happy to keep it fairly organic for now.

So yep, maybe makes sense to add under data augmentation for consistency as of now.

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@fabraz
Copy link
Contributor Author

fabraz commented Feb 7, 2023

Colab button and README.md cleared.

@andrewm4894
Copy link
Collaborator

notebook is looking a bit funny for some reason

seems like maybe some code cells and markdown getting messed up - is it just me?

https://github.com/fabraz/Open-Assistant/blob/writing_prompt/notebooks/data-augmentation/writing-prompt/writing_prompt.ipynb

image

@fabraz
Copy link
Contributor Author

fabraz commented Feb 9, 2023

So weird. It seems that it converted all the cells into a single one. Checking …

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@fabraz
Copy link
Contributor Author

fabraz commented Feb 10, 2023

@andrewm4894, I've found that the messy jupyter was due to a GitHub bug. When GH renders the following code, it lost any jupyter style setting thereafter.

image

I made some changes in the code, and now GH managed to present it correctly. Check it out.

I've done many commits for troubleshooting purposes. Let me know if it would be better to open another PR, to get rid of this commit messy history.

@andrewm4894
Copy link
Collaborator

oh interesting - ive seen markdown cells break github rendering before but never code cells lol

@andrewm4894
Copy link
Collaborator

i'm confused a bit by this - is that your gh username - im not sure if meant to be there or not?

image

@andrewm4894
Copy link
Collaborator

i also see an error so not all cells are rendered

ideally the notebooks would be a clean run top to bottom with all cells rendered so interested users can just read it before deciding if they want to play with it.

image

@fabraz
Copy link
Contributor Author

fabraz commented Feb 10, 2023

@andrewm4894 I removed unnecessary comments and fixed the cell with error output. Check, please!

@andrewm4894 andrewm4894 merged commit bfccb51 into LAION-AI:main Feb 10, 2023
@olliestanley
Copy link
Collaborator

This should have had the .ipynb_checkpoints dir removed before merge really. Ah well

@andrewm4894
Copy link
Collaborator

#1358

Waiting to merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants