Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added column to post table for lang with US english set to default. #128

Merged
merged 3 commits into from Dec 29, 2022
Merged

Added column to post table for lang with US english set to default. #128

merged 3 commits into from Dec 29, 2022

Conversation

GraemeHarris
Copy link
Collaborator

Simple updates to add a column for the lang field +migration - can be expanded upon down the line
For the issue Open-Assistant #93

andreaskoepf
andreaskoepf approved these changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks a lot! :-)

@yk yk linked an issue Dec 29, 2022 that may be closed by this pull request
Add lang column to post table (ISO 639-1 code) #93
Closed
@yk
Copy link
Collaborator

yk commented Dec 29, 2022

give it a pre-commit run --all-files once, and run pre-commit install for the future

@yk yk merged commit 3ab2e01 into LAION-AI:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@yk yk Awaiting requested review from yk yk is a code owner

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add lang column to post table (ISO 639-1 code)
4 participants
@GraemeHarris @yk @andreaskoepf @fozziethebeat