Admin user management #1393
Merged
Admin user management #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmd
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
notmd
commented
Feb 9, 2023
| cell: ({ getValue }) => ( | ||
| <DataTableAction | ||
| as={NextLink} | ||
| href={ROUTES.ADMIN_MESSAGE_DETAIL(getValue())} |
There was a problem hiding this comment.
this page doesn't exists yet, I will add it in the next PR
AbdBarho
reviewed
Feb 9, 2023
| }); | ||
| }; | ||
|
|
||
| const resetCursor = () => setPagination((old) => ({ ...old, cursor: "" })); |
There was a problem hiding this comment.
useCallback for these 3 functions.
There was a problem hiding this comment.
These 3 function will need a wrapper function to pass data, so useCallback has no effect here.
| import { Badge, Flex } from "@chakra-ui/layout"; | ||
| import { Tooltip } from "@chakra-ui/react"; | ||
| import { createColumnHelper } from "@tanstack/table-core"; | ||
| import { formatDistanceToNow, formatISO9075 } from "date-fns"; |
There was a problem hiding this comment.
I wonder if this is something that next-i18n already provides.
There was a problem hiding this comment.
From my knowledge, the answer is no. I'm pretty sure we'd have to use some new library to do this so date-fns seems good enough
There was a problem hiding this comment.
Since @AbdBarho left some good comments, I have nothing else to add. Looks fine after those changes.
fozziethebeat
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1022
UI
