Add tests and update docstring to tokenizer matching #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackapbutler
changed the title
sanagno
reviewed
Feb 10, 2023
model/supervised_finetuning/utils.py
Outdated
| @@ -37,7 +37,7 @@ class TokenizerConfig(NamedTuple): | |||
|
|
|||
| def match_tokenizer_name(model_name: str) -> TokenizerConfig: | |||
| """Match a partial model name to a tokenizer configuration""" | |||
| tokenizer_config_matches = [config for name, config in TOKENIZER_CONFIGS.items() if name in model_name] | |||
| tokenizer_config_matches = [config for name, config in TOKENIZER_CONFIGS.items() if model_name in name] | |||
There was a problem hiding this comment.
It was already correct, no? We call match_tokenizer_name based on the name of the model not the keys of TOKENIZER_CONFIGS
There was a problem hiding this comment.
Hey @sanagno, yes you're right actually. I've just updated it back and added some docstrings / tests to make it clearer.
jackapbutler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does performs some minor updates;
get_tokenizer