Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: romanian #1414

Merged
merged 5 commits into from Feb 13, 2023
Merged

feat: romanian #1414

merged 5 commits into from Feb 13, 2023

Conversation

MrlolDev
Copy link
Contributor

Added full romanian translation, I am not native speaker so it can has some errors of expressions but the same happens with other languages.

@MrlolDev
Copy link
Contributor Author

Any help with the error pls?

@AbdBarho
Copy link
Collaborator

@MrlolDev rebase your code on top of main, the error should be fixed.

fozziethebeat
fozziethebeat requested changes Feb 11, 2023
View reviewed changes
Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, could up merge in the recent changes from main? That should fix the end2end test failure.

website/public/locales/ro/side_menu.json Outdated Show resolved Hide resolved
AbdBarho
AbdBarho approved these changes Feb 11, 2023
View reviewed changes
Copy link
Collaborator

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fozziethebeat fozziethebeat merged commit 38412ab into LAION-AI:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fozziethebeat fozziethebeat fozziethebeat approved these changes

@AbdBarho AbdBarho AbdBarho approved these changes

@k-nearest-neighbor k-nearest-neighbor Awaiting requested review from k-nearest-neighbor

@notmd notmd Awaiting requested review from notmd notmd is a code owner

Assignees
No one assigned
Labels
i18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrlolDev @AbdBarho @fozziethebeat