Use docker compose profiles for all services #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdBarho
force-pushed
the
compose-profiles
branch
from
bb48bdc
to
ecf5319
Compare
AbdBarho
force-pushed
the
compose-profiles
branch
from
ecf5319
to
22c6c42
Compare
AbdBarho
force-pushed
the
compose-profiles
branch
from
22c6c42
to
46dc3e5
Compare
AbdBarho
requested review from
fozziethebeat,
k-nearest-neighbor,
notmd,
yk and
andreaskoepf
as code owners
fozziethebeat
approved these changes
Feb 10, 2023
Merged
andreaskoepf
approved these changes
Feb 12, 2023
AbdBarho
added a commit
that referenced
this pull request
Feb 21, 2023
~~Blocked by #1418~~ This feature is currently hidden behind a flag, so deployment is not a problem, also, there are no inference servers! https://user-images.githubusercontent.com/24505302/217936648-09e79be0-a04e-475d-82bd-50bfd11a8d21.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how it is done for the inference services.
I hope I didn't forget to update any file.
I don't think this affects deployment