Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more datasets and some fixes #1455

Merged
merged 13 commits into from Feb 11, 2023
Merged

Add more datasets and some fixes #1455

merged 13 commits into from Feb 11, 2023

Conversation

theblackcat102
Copy link
Collaborator

  1. Mainly added OA private datasets :
  • essay_instruction : essay writing
  • private_tuning : new instruction generated dataset
  • translated instruction : translated instruction of the above
  • eli5 : askh, eli5, asks dataset
  1. Added collate function for mixing different tasks during in batch to make sure the attention learns to attention relevant previous context and question

  2. Fix bugs from other PR

@sanagno
Copy link
Collaborator

sanagno commented Feb 11, 2023

Thanks!
We can merge, I would propose some simple changes.

  1. Add a flag to choose whether to use the new mixing in the collator
  2. Add a script to split the OAPrivate data for sft, rm and rl
  3. I would merge all the data utils from the sft, rm and rl, let me know if you agree I can do it today-tomorrow.


# Add a way for the model to terminate generation
# When we predict the start of a new expected question, we want to be able to stop generation
messages.append(self.tokenizer.eos_token)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this collator to work, we need to replace this eos token with the tag. Let me know if I am wrong.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change it anyway, for both this collator and the default collator

Copy link
Collaborator

@sanagno sanagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge for now, and I can make some changes now

@sanagno sanagno merged commit 0610865 into main Feb 11, 2023
@sanagno sanagno deleted the add-dataset branch February 11, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants