Fix jest unit test #1495
Merged
Fix jest unit test #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…making warns and errors fatal
…is not used here. Setup is done in jest.setup.js
johnflux
requested review from
fozziethebeat,
k-nearest-neighbor,
AbdBarho and
notmd
as code owners
fozziethebeat
added
assistant-evaluation
website
and removed
assistant-evaluation
labels
fozziethebeat
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was broken because it required i18n to be stubbed, but because it was indicating this with a console warning, it wasn't noticed.
I've stubbed i18n and also made warn's and error's fatal (unless overridden otherwise)