Updated join-us and FAQ links #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billray0259
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
AbdBarho
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
@billray0259 thank you!
This solves the problem for the login / sign up page, but not for other pages.
That being said, I think the problem is much bigger in how we structure the site. In our index.tsx we show two different pages if the user is signed in vs not.
I think it would make sense to leave / as non-logged user, and maybe add a /dashboard that shows the available tasks.
@billray0259 what do you think?
This is totally out of scope of this PR, I will create a follow up issue. #156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was easier to update the links than to remove the buttons on the sign-up page.
resolves #132